Conversation
Signed-off-by: Pavel Kirilin <win10@list.ru>
Signed-off-by: Pavel Kirilin <win10@list.ru>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #226 +/- ##
===========================================
- Coverage 73.45% 73.04% -0.42%
===========================================
Files 55 56 +1
Lines 1646 1684 +38
===========================================
+ Hits 1209 1230 +21
- Misses 437 454 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new abstraction called "CreatedSchedule". When
schedule_*methods are called, theCreatedScheduleis returned. This class has methods to unschedule previously scheduled tasks.Also, we added new method to the schedule source to remove schedules. To make this method easy to implement, we had to once again add new field
schedule_idto theScheduledTask. To make it backward compatible though, we made it with default_factory.